Re: Add some regression tests for SEQUENCE - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Add some regression tests for SEQUENCE
Date
Msg-id CA+TgmoYz-AFWqNo0WMwF_Mc+JuQd8fXo-vALNd+hsrEFEoy8MA@mail.gmail.com
Whole thread Raw
In response to Re: Add some regression tests for SEQUENCE  (Robins Tharakan <tharakan@gmail.com>)
Responses Re: Add some regression tests for SEQUENCE
List pgsql-hackers
On Tue, May 7, 2013 at 6:40 PM, Robins Tharakan <tharakan@gmail.com> wrote:
> Have provided an updated patch as per Fabien's recent response on Commitfest
> site.
> Any and all feedback is appreciated.

I think you should rename the roles used here to regress_rol_seq1 etc.
to match the CREATE OPERATOR patch.

And you need to update the expected output.

Setting this one to "Waiting on Author".

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: (trivial patch) remove superfluous semicolons from pg_dump
Next
From: Bruce Momjian
Date:
Subject: Re: possible/feasible to specify field and value in error msg?