Re: [HACKERS] Unused variable scanned_tuples in LVRelStats - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Unused variable scanned_tuples in LVRelStats
Date
Msg-id CA+TgmoYydRzM_V+363s1r2jMt9RRCQ5RoDz5fHt+m1MgtswRDg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Unused variable scanned_tuples in LVRelStats  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] Unused variable scanned_tuples in LVRelStats  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> So we can remove scanned_tuples from LVRelStats struct and change the
> variable name num_tuples to scanned_tuples. Attached updated patch.

On second thought, I think we should just leave this alone.
scanned_tuples is closely tied to tupcount_pages, so it's a little
confusing to pull one out and not the other.  And we can't pull
tupcount_pages out of LVRelStats because lazy_cleanup_index needs it.
The current situation isn't doing any harm, so I'm not seeing much
point in changing it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Douglas Doole
Date:
Subject: [HACKERS] Tightly packing expressions
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] Tightly packing expressions