Re: clog double-dip in heap_hot_search_buffer - Mailing list pgsql-hackers

From Robert Haas
Subject Re: clog double-dip in heap_hot_search_buffer
Date
Msg-id CA+TgmoYt0WYGxdjJYUVdw8jFfnBPmzV5Q2tzTjd3-RJhbnGvCQ@mail.gmail.com
Whole thread Raw
In response to Re: clog double-dip in heap_hot_search_buffer  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: clog double-dip in heap_hot_search_buffer
Re: clog double-dip in heap_hot_search_buffer
List pgsql-hackers
On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
>
> s/alive/dead/ in that comment?

Yep, good catch, thanks.

> Otherwise this seems like a good idea.

Do you think I should apply this to 9.2, or wait until 9.3?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: clog double-dip in heap_hot_search_buffer
Next
From: Simon Riggs
Date:
Subject: Re: Temporary tables under hot standby