Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding
Date
Msg-id CA+TgmoYmM4him2vWioQCKziYy5BaCz1RszAbGk3VX=dScB1=mg@mail.gmail.com
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Sat, Jun 8, 2013 at 10:25 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
> Don't downcase non-ascii identifier chars in multi-byte encodings.
>
> Long-standing code has called tolower() on identifier character bytes
> with the high bit set. This is clearly an error and produces junk output
> when the encoding is multi-byte. This patch therefore restricts this
> activity to cases where there is a character with the high bit set AND
> the encoding is single-byte.
>
> There have been numerous gripes about this, most recently from Martin
> Schäfer.
>
> Backpatch to all live releases.

I'm all for changing this, but back-patching seems like a terrible
idea.  This could easily break queries that are working now.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: Re: Hard limit on WAL space used (because PANIC sucks)
Next
From: Robert Haas
Date:
Subject: Re: Optimising Foreign Key checks