Postgres Pro
Downloads
Home   >   mailing lists

Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs
Date
Msg-id CA+TgmoYmKZqKhkRs7LzFM9qKYZ=unnk-tuPhOk3vd_GWXDqaxQ@mail.gmail.com
Whole thread Raw
In response to Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs
List pgsql-hackers
Tree view 
On Thu, May 22, 2014 at 12:18 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Thu, May 22, 2014 at 12:44 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> Hi all,
>>
>> As written in subject, replication protocol documentation lacks
>> details about logical slots in CREATE_REPLICATION_SLOT command:
>> http://www.postgresql.org/docs/devel/static/protocol-replication.html
>> Attached is a patch correcting that.
> An additional thing I noticed: START_REPLICATION does not mention that
> it is possible to specify options for the output plugin. All the fixes
> are included in the patch attached.

Thanks, this looks good.  But shouldn't the bit about output plugin
options mention say something like:

( option_name option_argument [, ...] )

...instead of just:

( option [, ...] )

?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful
Next
From: Heikki Linnakangas
Date:
Subject: Re: CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful