Postgres Pro
Downloads
Home   >   mailing lists

Re: Tighten error control for OpenTransientFile/CloseTransientFile - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Tighten error control for OpenTransientFile/CloseTransientFile
Date
Msg-id CA+TgmoYb00PYSVQc5L-DGjq91DXfimCevr0_mL8fcbbNpe58Kg@mail.gmail.com
Whole thread Raw
In response to Re: Tighten error control for OpenTransientFile/CloseTransientFile  (Joe Conway <mail@joeconway.com>)
List pgsql-hackers
Tree view 
On Fri, Mar 1, 2019 at 5:06 PM Joe Conway <mail@joeconway.com> wrote:
> Seems like it would be better to modify the arguments to
> CloseTransientFile() to include the filename being closed, errorlevel,
> and fail_on_error or something similar. Then all the repeated ereport
> stanzas could be eliminated.

Hmm.  I'm not sure that really saves much in terms of notation, and
it's less flexible.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Binary upgrade from <12 to 12 creates toast table for partitionedtables
Next
From: Robert Haas
Date:
Subject: Re: Making all nbtree entries unique by having heap TIDs participatein comparisons