Re: 16-bit page checksums for 9.2 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: 16-bit page checksums for 9.2
Date
Msg-id CA+TgmoYFk8eHs+AnDbE4hd3RDHTeVOta0R0upmEK7ay3D-ye-Q@mail.gmail.com
Whole thread Raw
In response to Re: 16-bit page checksums for 9.2  (Dan Scales <scales@vmware.com>)
Responses Re: 16-bit page checksums for 9.2  (Dan Scales <scales@vmware.com>)
List pgsql-hackers
On Thu, Jan 26, 2012 at 7:01 PM, Dan Scales <scales@vmware.com> wrote:
> I'm not sure why you moved the checksum calculation (PageSetVerificationInfo) to mdwrite() rather than smgrwrite().
 Ifthere were every another storage backend, it would have to duplicate the checksum check, right?  Is there a
disadvantageto putting it in smgrwrite()? 

The smgr and md layers don't currently know anything about the page
format, and I imagine we want to keep it that way.  It seems like the
right place for this is in some higher layer, like bufmgr.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: patch: ALTER TABLE IF EXISTS
Next
From: Heikki Linnakangas
Date:
Subject: Re: Group commit, revised