Re: pgsql: Drop unnamed portal immediately after execution to completion - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: Drop unnamed portal immediately after execution to completion
Date
Msg-id CA+TgmoYFJyJNQw3RT7veO3M2BWRE9Aw4hprC5rOcawHZti-f8g@mail.gmail.com
Whole thread Raw
Responses Re: pgsql: Drop unnamed portal immediately after execution to completion
List pgsql-hackers
On Wed, Nov 5, 2025 at 12:43 AM Michael Paquier <michael@paquier.xyz> wrote:
> Drop unnamed portal immediately after execution to completion

This patch doesn't look well-considered to me. One problem is that
it's a wire protocol change to fix a minor logging anomaly, which
seems disproportionate. Another problem is that the new portal-drop
behavior is conditional on whether XACT_FLAGS_NEEDIMMEDIATECOMMIT gets
set, which seems unprincipled. In addition to those points, I am not
entirely certain that the "here is no need for it beyond this point"
comment is correct. I mean, I think it will normally be true, but what
if the client wants to send a Describe message after-the-fact, or an
additional Execute message that will presumably return zero rows?

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: "Jelte Fennema-Nio"
Date:
Subject: Re: RFC: adding pytest as a supported test framework
Next
From: Nathan Bossart
Date:
Subject: Re: vacuumdb: add --dry-run