Re: __attribute__ for non-gcc compilers - Mailing list pgsql-hackers

From Robert Haas
Subject Re: __attribute__ for non-gcc compilers
Date
Msg-id CA+TgmoYEcz9G9CBd4E05bWPZ=OxiySL8SX6OD_MXwBwunmbq-w@mail.gmail.com
Whole thread Raw
In response to Re: __attribute__ for non-gcc compilers  (Oskari Saarenmaa <os@ohmu.fi>)
Responses Re: __attribute__ for non-gcc compilers  (Oskari Saarenmaa <os@ohmu.fi>)
List pgsql-hackers
On Tue, Feb 17, 2015 at 8:41 AM, Oskari Saarenmaa <os@ohmu.fi> wrote:
> 15.01.2015, 21:58, Robert Haas kirjoitti:
>> On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>>> I think I'd for now simply not define pg_attribute_aligned() on
>>> platforms where it's not supported, instead of defining it empty. If we
>>> need a softer variant we can name it pg_attribute_aligned_if_possible or
>>> something.
>>>
>>> Sounds sane?
>>
>> Yes, that sounds like a much better plan.
>
> Attached an updated patch rebased on today's git master that never
> defines aligned or packed empty.
>
> This is also included in the current commitfest,
> https://commitfest.postgresql.org/4/115/

Is this going to play nicely with pgindent?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Redesigning checkpoint_segments
Next
From: Tomas Vondra
Date:
Subject: Re: a fast bloat measurement tool (was Re: Measuring relation free space)