On Fri, Jan 27, 2012 at 10:58 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> It's not clear to me why fmtQualifiedId needs to move to dumputils.c.
>> The way you have it, fmtQualifiedId() is now with fmtId(), but no
>> longer with fmtCopyColumnList(), the only other similarly named
>> function in that directory. That may be more logical, or it may not,
>> but rearranging the code like this makes it a lot harder to review,
>> and I would prefer that we make such changes as separate commits if
>> we're going to do them, so that diff can do something sensible with
>> the changes that are integral to the patch.
>
> Woops, hit send a little too soon there. I'll try to make some more
> substantive comments after looking at this more.
And maybe retract some of the bogus ones, like the above: I see why
you moved this, now - parallel.c needs it.
Still looking...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
