Re: Wait free LW_SHARED acquisition - v0.2 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Wait free LW_SHARED acquisition - v0.2
Date
Msg-id CA+TgmoY9+bE6Zpz9goRNHnOXsXEw51jv-eptK+AdoLL4rrmhHQ@mail.gmail.com
Whole thread Raw
In response to Re: Wait free LW_SHARED acquisition - v0.2  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Wait free LW_SHARED acquisition - v0.2
Re: Wait free LW_SHARED acquisition - v0.2
List pgsql-hackers
On Wed, Oct 8, 2014 at 8:47 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> I don't see that as being relevant. The difference is an instruction or
> two - in the slow path we'll enter the kernel and sleep. This doesn't
> matter in comparison.
> And the code is *so* much more readable.

I find the slist/dlist stuff actually quite difficult to get right
compared to a hand-rolled linked list.  But the really big problem is
that the debugger can't do anything useful with it.  You have to work
out the structure-member offset in order to walk the list and manually
cast to char *, adjust the pointer, and cast back.  That sucks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Paweł Cesar Sanjuan Szklarz
Date:
Subject: Re: Context lenses to set/get values in json values.
Next
From: Andres Freund
Date:
Subject: Re: Wait free LW_SHARED acquisition - v0.2