Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0
Date
Msg-id CA+TgmoY6hKiPsHqbbM42WAN4jDfUu4jDZaq9O7S-_HugW_iBmA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
On Wed, Dec 14, 2016 at 2:34 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>> Okay, but I think we need to re-enable the existing event handle for
>> required event (FD_READ) by using WSAEventSelect() to make it work
>> sanely.  We have tried something on those lines and it resolved the
>> problem.  Ashutosh will post a patch on those lines later today.  Let
>> us know if you have something else in mind.
>
> Attached is the patch based on Amit's explanation above. Please have a
> look and let me know for any concerns. Thank you Micheal and Andres
> for sharing your thoughts and Amit for your valuable inputs.

One immediate concern is that the patch has no comments.  Considering
this seems to be a pretty tricky issue, that seems like a problem.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0