Re: psql completion for ids in multibyte string - Mailing list pgsql-hackers

From Robert Haas
Subject Re: psql completion for ids in multibyte string
Date
Msg-id CA+TgmoY0oOCJFURtjv4QkuEsSVLTJDG+rgmX=APRVf++oUwQSw@mail.gmail.com
Whole thread Raw
In response to Re: psql completion for ids in multibyte string  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: psql completion for ids in multibyte string
List pgsql-hackers
On Wed, Mar 2, 2016 at 8:07 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, thank you for the comments.
>> I think we should leave string_length as it is and use a new variable
>> for character-based length, as in the attached.
>
> Basically agreed but I like byte_length for the previous
> string_length and string_length for string_length_cars. Also
> text_length is renamed in the attached patch.

I committed this and back-patched this but (1) I avoided changing the
other functions for now and (2) I gave both the byte length and the
character length new names to avoid confusion.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: GetExistingLocalJoinPath() vs. the docs
Next
From: Alvaro Herrera
Date:
Subject: Re: psql completion for ids in multibyte string