Re: PATCH: Add 'pid' column to pg_replication_slots - Mailing list pgsql-hackers

From Robert Haas
Subject Re: PATCH: Add 'pid' column to pg_replication_slots
Date
Msg-id CA+TgmoY+nRAjYZU2nobxddPV_=i9c2D60C34NOonTb8gzgefOg@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Add 'pid' column to pg_replication_slots  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: PATCH: Add 'pid' column to pg_replication_slots
List pgsql-hackers
On Tue, Apr 21, 2015 at 6:17 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
>> I don't really like the 'pid' field for pg_replication_slots. About
>> naming it 'active_in' or such?
>
> It was originally named active_pid, but changed based on feedback from
> others that 'pid' would be consistent with pg_stat_activity and
> pg_replication_slots. I have no strong opinion on the name, though I'd
> prefer it reflect that the field does in fact represent a process ID.

Agreed.  I don't like the as-committed name of active_in either.  It's
not at all clear what that means.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Parallel Seq Scan
Next
From: Andres Freund
Date:
Subject: Re: PATCH: Add 'pid' column to pg_replication_slots