On Jul 21, 2018 12:33 PM, "David Fetter" <david@fetter.org> wrote:
On Sat, Jul 21, 2018 at 12:00:48PM -0700, Charles Cui wrote: > 2018-07-20 2:18 GMT-07:00 Aleksander Alekseeev <a.alekseev@postgrespro.ru>: > > > Hello Charles, > > > > > Here is my current working status. > > > 1. Complete the thrift_binary_in and thrift_binary_out functions, so > > > that users can express their thrift struct using json. These two > > > functions support both simple data struct and complex data structure > > > like struct and map. 2. added test cases and document to cover > > > thrift_binary_in and thrift_binary_out. 3. make the code compile-able > > > from 9.4 to 11.0. > > > > I see multiple warnings during compilation with 11.0, e.g: > > > > ``` > > pg_thrift.c:1120:72: warning: implicit declaration of function > > ‘JsonbGetDatum’; did you mean ‘JsonbPGetDatum’? > > [-Wimplicit-function-declaration] > > > > pg_thrift.c:1206:13: warning: the address of ‘is_big_endian’ will > > always evaluate as ‘true’ [-Waddress] > > > > pg_thrift.c:1227:18: warning: implicit declaration of function > > ‘PG_GETARG_JSONB’; did you mean ‘PG_GETARG_JSONB_P’? > > [-Wimplicit-function-declaration] > > > > pg_thrift.c:1227:18: warning: initialization of ‘Jsonb *’ {aka ‘struct > > <anonymous> *’} from ‘int’ makes pointer from integer without a cast > > [-Wint-conversion] > > ``` > > > > Also tests (make clean && make && make install && make installcheck) > > don't pass. > > > I have tested compiled passed for 9.4, 9.5, 9.6, 10 and 11 ( > https://travis-ci.org/charles-cui/pg_thrift/builds/404741899) > and make install && make installcheck passed for 9.4 > The tests are not run for other versions because my mac is 9.4 postgresql.
You can have several versions of PostgreSQL on your mac at once. Are you using homebrew?
Best, David.
-- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778
