Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters) - Mailing list pgadmin-hackers

From Sachin Srivastava
Subject Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)
Date
Msg-id CA+RD+kh6L6vZAk3wicnyd9TFSMLmzqPHSXn8oH_M4Bzbf4zMew@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Sure, I am on it..

On Wed, Apr 11, 2012 at 3:50 PM, Dave Page <dpage@pgadmin.org> wrote:
Sachin, could you review this please? I'm swamped right now.

Thanks.


On Mon, Apr 9, 2012 at 7:15 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

During resolving a bug - "Error message is displayed when the packages is clicked", I found that:
- We are not properly handling the default parameters for the functions & procedures properly, when the function is type of 'edbspl'.
- We also do not handle the default parameters for the functions & procedures properly under the packages.

In 'edbspl', we do not allow the default parameters with INOUT parameters and that reflects in the reverse-engineering for those functions & procedures.

Attached patches resolve the above issues for REL-1_14 and master branches.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Regards,
Sachin Srivastava
EnterpriseDB, India

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin 1.15 experiences
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Use an enum for tabs instead of real numbers