Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters) - Mailing list pgadmin-hackers

From Sachin Srivastava
Subject Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)
Date
Msg-id CA+RD+kgB1Tz6HU+1aw9HCScwAkbog_ZEzQkcPPka0YAAqu=Czg@mail.gmail.com
Whole thread Raw
In response to PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)
List pgadmin-hackers
Tree view

Ashesh,

In this code block,

360 +                                       (function->GetArgModesArray()[index] == wxT("INOUT") &&
361 +                                        lanname != wxT("edbsql")) ||
362 +                                       function->GetArgModesArray()[index] == wxT("VARIADIC"))


lanname should be comapred to 'edbspl'.

Rest all looks good.


On Mon, Apr 9, 2012 at 12:45 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

During resolving a bug - "Error message is displayed when the packages is clicked", I found that:
- We are not properly handling the default parameters for the functions & procedures properly, when the function is type of 'edbspl'.
- We also do not handle the default parameters for the functions & procedures properly under the packages.

In 'edbspl', we do not allow the default parameters with INOUT parameters and that reflects in the reverse-engineering for those functions & procedures.

Attached patches resolve the above issues for REL-1_14 and master branches.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Regards,
Sachin Srivastava
EnterpriseDB, India

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Use an enum for tabs instead of real numbers
Next
From: Ashesh Vashi
Date:
Subject: Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)