Home > mailing lists

Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connectiontimeout on the server properties dialog - Mailing list pgadmin-hackers

From	Dave Page
Subject	Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connectiontimeout on the server properties dialog
Date	June 18, 2018 23:09:04
Msg-id	CA+OCxozvzpGn2QQnutxLwAhV8Ag1Aze-jGn9EtuEQiuGS89YYw@mail.gmail.com Whole thread Raw
In response to	[pgadmin4][Patch]: Feature #3388 Allow to set the connection timeouton the server properties dialog (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses	Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connectiontimeout on the server properties dialog (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List	pgadmin-hackers

On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch for Feature #3388 Allow to set the connection timeout on the server properties dialog. Please review it.

I took a quick look at this and had some questions/comments:

- Doc updates seem to be missing.

- The timeout should be passed through to external utilities like pg_dump/pg_restore.

- Can/should the timeout be extended to the SSH tunnels?

- Any refactoring opportunities in the code you're touching?

Thanks.

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

From: pgAdmin 4 Jenkins
Date: 18 June 2018, 22:56:26
Subject: Jenkins build is back to normal : pgadmin4-master-python33 #664

From: Dave Page
Date: 18 June 2018, 23:43:15
Subject: pgAdmin 4 commit: Ensure that template0 and template1 are availableas