Re: [pgAdmin4][Patch]: RM#1366 - NOICONS switch for windows installer. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM#1366 - NOICONS switch for windows installer.
Date
Msg-id CA+OCxoztvSTOx7XxyFJDpdt_E0ZVe6avn5gFk7e76j9mXsgRYw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM#1366 - NOICONS switch for windows installer.  (Paresh More <paresh.more@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Sun, Nov 19, 2017 at 3:20 PM, Paresh More <paresh.more@enterprisedb.com> wrote:
Hi,

This is regarding patch for RM#1366:  Installer: pgadmin4-1.0-beta1.exe /NOICONS switch issue

This patch includes:
- It would work for both normal and commandline mode when NOICONS argument is passed.

In Normal mode
Don't create a Start Menu folder option checkbox will be uncheck by default. i.e Start Menu folder would be created by default.

In commandline when NOICONS is passed
Don't create a Start Menu folder option checkbox will be checked by default.
i.e Start Menu folder will not be created by default.

Please Note : As per documentation of Inno tool.

/NOICONS

Instructs Setup to initially check the Don't create a Start Menu folder check box on the Select Start Menu Folder wizard page.


User still have a option at runtime whether he want to create or not create Start Menu folder on runtime. NOICONS will just uncheck the checkbox.


Attached is the patch.

--

Thanks & Regards

Paresh More

NEW-EDB-logo-4c

Pune, India.




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix /NOICONS switch in the windows installer. Fixes#
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python34 #376