Hi Ashesh,As discussed please find updated patch removing hardcoded check for server & server-group node.--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL CompanyOn Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Ashesh,PFA updated patch for the issue.--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL CompanyOn Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? Thanks.On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 commit .RM#2355We should remove the existing node, and then insert at right place instead of refreshing the parent.Because - that will select the parent node, and not that node, and also - it adds overhead of refreshing the whole parent node.Please send the patch as per our discussion.-- Thanks, Ashesh--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Hi Ashesh,PFA updated patch for the issue.--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL CompanyOn Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? Thanks.On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 commit .RM#2355We should remove the existing node, and then insert at right place instead of refreshing the parent.Because - that will select the parent node, and not that node, and also - it adds overhead of refreshing the whole parent node.Please send the patch as per our discussion.-- Thanks, Ashesh--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? Thanks.On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 commit .RM#2355We should remove the existing node, and then insert at right place instead of refreshing the parent.Because - that will select the parent node, and not that node, and also - it adds overhead of refreshing the whole parent node.Please send the patch as per our discussion.-- Thanks, Ashesh--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Ashesh, can you review/commit this please? Thanks.On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 commit .RM#2355
Hi,PFA minor patch to fix the issue where node rename is not working properly after 7dd9efd8 commit .RM#2355
--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
--Regards,Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных