Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice inDebug mode - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice inDebug mode
Date
Msg-id CA+OCxozbwH1sa2bwpXMoR+RXeiVzE_XJSt0katGx_CSDchu1=Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice inDebug mode  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice inDebug mode
List pgadmin-hackers
Tree view
Thanks, applied. The reloader has always been a little temperamental for me, so I couldn't prove this doesn't break it. If someone finds it does, please yelp. 

On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

In this patch, i have added reference to the implementation.
Please find updated patch and review.

Thanks,
Surinder

On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in non-DEBUG mode, once. It is pain while development because `yarn run bundle` also runs twice.

It is because the parameter `use_reloader` = True in Debug Mode.

If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to None, i.e. app is starting for the first time and then its value is changed to True.

Please find attached patch.

Thanks
Surinder







--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Prevent the Werkzeug reloader from causing a"double
Next
From: Dave Page
Date:
Subject: Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling