Re: zlib detection in Meson on Windows broken? - Mailing list pgsql-hackers

From Dave Page
Subject Re: zlib detection in Meson on Windows broken?
Date
Msg-id CA+OCxozWrQjqBMLMotGt_yWm+=DBsvxhHwGWRNi8Fu+=W6Bm8Q@mail.gmail.com
Whole thread Raw
In response to Re: zlib detection in Meson on Windows broken?  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers


On Tue, 21 May 2024 at 20:54, Andrew Dunstan <andrew@dunslane.net> wrote:

On 2024-05-21 Tu 11:04, Andres Freund wrote:
> Hi,
>
> On 2024-05-20 11:58:05 +0100, Dave Page wrote:
>> I have very little experience with Meson, and even less interpreting it's
>> logs, but it seems to me that it's not including the extra lib and include
>> directories when it runs the test compile, given the command line it's
>> reporting:
>>
>> cl C:\Users\dpage\git\postgresql\build\meson-private\tmpg_h4xcue\testfile.c
>> /nologo /showIncludes /utf-8 /EP /nologo /showIncludes /utf-8 /EP /Od /Oi-
>>
>> Bug, or am I doing something silly?
> It's a buglet. We rely on meson's internal fallback detection of zlib, if it's
> not provided via pkg-config or cmake. But it doesn't know about our
> extra_include_dirs parameter. We should probably fix that...
>

Yeah. Meanwhile, what I got working on a totally fresh Windows + VS
install was instead of using extra_include_dirs etc to add the relevant
directories to the environment LIB and INCLUDE settings before calling
`"meson setup".

Yes, that works for me too.
 
--

pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: zlib detection in Meson on Windows broken?
Next
From: Peter Eisentraut
Date:
Subject: Re: in parentesis is not usual on DOCs