Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin 1.15 experiences - Mailing list pgadmin-hackers

From Dave Page
Subject Re: pgAdmin 1.15 experiences
Date
Msg-id CA+OCxoz3B82cfusskXyPZzsemJH6i2cz-JecOVTYZ-0RtSwADg@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin 1.15 experiences  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: pgAdmin 1.15 experiences  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers
Tree view
That looks OK to me - thanks. Guillaume, what do you think (it's fixing a bug in your code :-) ). Basically the problem is in the code you added to prevent the same properties dialogue being opened twice, or dropping of objects that are open in dialogues. The issue was that the code always assumed the selected item in the treeview was the item on which it was acting, which is not always the case (for example, you might double-click an item in the listview).

On Wed, Mar 28, 2012 at 10:25 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi 

I am able to reproduce the bug as per the steps given by Wahlstedt Jyrki. I have tried to fix the crash and it is working for me. Attached is the patch file. Please review it. If solution looks good then please commit the code.

On Wed, Mar 21, 2012 at 10:46 PM, Wahlstedt Jyrki <jwa@wahlstedt.fi> wrote:

On 15.3.2012, at 11.24, Akshay Joshi wrote:



On Wed, Mar 14, 2012 at 10:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay; could you investigate please?

   Not able to reproduce the bug on OSX 10.6.8 with Postgres 9.0. I don't have OSX version 10.7.3 



Hi,
I suppose I wasn't totally clear when showing how the crash occurred:
1) I opened pgAdmin (obviously), and connected to server, then clicked on 'Tables' in the left-hand pane.
2) Then I double-clicked a table name in the right-hand pane (like scoringsystem below).
3) Then crash (the window for the table is created, but is all grey)

This is just a check, I don't hope there is a crash, though it could make debugging easier…


with best greetings,

Jyrki Wahlstedt





--
Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: pgAdmin 1.15 experiences
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin website commit: Fix a URL