Re: [pgadmin-hackers] javascript and css minification process - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers] javascript and css minification process
Date
Msg-id CA+OCxoz2k6PjgGXo4H+h6JozOvLy5C_uGxU7+CjxVs0LoKL+zQ@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] javascript and css minification process  (George Gelashvili <ggelashvili@pivotal.io>)
Responses Re: [pgadmin-hackers] javascript and css minification process
List pgadmin-hackers
Hi

On Fri, May 12, 2017 at 3:29 PM, George Gelashvili <ggelashvili@pivotal.io> wrote:
Hello

We're looking at the js and css minimization python code to investigate minification as part of the pgadmin artifact build process.

We're wondering why minimise.py is currently only manually invokable, via the minimise make step.

Also it seems like currently, minimise.py's dependencies (rcssmin and rjsmin) are not being included in any requirements.txt

When is the minification performed?

It's not yet. Those are utility scripts that I was eventually intending to call from appropriate make targets during package build. Before we get there though, we need code changes to ensure that we load minified code vs. debug code at the appropriate times. I haven't done much with it in a while as Tira had been talking about transpiling everything into a single blob (though that required us to ensure none of the JS files were Jinja templates any more). 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: George Gelashvili
Date:
Subject: [pgadmin-hackers] javascript and css minification process
Next
From: George Gelashvili
Date:
Subject: Re: [pgadmin-hackers] javascript and css minification process