Re: Procedure "RENAME, SET SCHEMA" issues patch. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Procedure "RENAME, SET SCHEMA" issues patch.
Date
Msg-id CA+OCxoy_kvAyB1=Dd1SRgJ9inEqE8Axj88XPP1t_k28nyD5LoQ@mail.gmail.com
Whole thread Raw
In response to Re: Procedure "RENAME, SET SCHEMA" issues patch.  (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
List pgadmin-hackers
Thanks - patch applied.

Regards, Dave.


On Wed, May 8, 2013 at 7:51 AM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
H
i Dave,

On Tue, May 7, 2013 at 9:14 AM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Dear Team,

I would like to submit a patch for the Procedure "RENAME, SET SCHEMA" issue.

Issue:
====
If we try to rename the Procedure from the pgAdmin 1.16 by it's properties dialogue window, then we will get "ERROR: syntax error at or near RENAME".

Attached the screen shot of this issue, and the bug fix.

Thanks in advance.

Have you tested this with older versions of PPAS (i.e. 8.4)? If memory serves, the were inconsistencies in the way procedure modifications we made in older versions.

I have tested the same case against PPAS 8.4 with pgAdmin 1.16 and got the same error. And i have my old setup, which is PPAS 8.3R2 and PEM (2.0.2) and it is working fine.


Also, is changing of the owner not supported? The patch seems to remove code to deal with that.

 
Sorry Dave, It's my mistake. I have double checked the ownership changes of procedure and included the respective call function in place.

Attaching the new patch.

Thanks in advance.

 
Dinesh

-- 
Dinesh Kumar
Software Engineer
Skype ID: dinesh.kumar432
www.enterprisedb.com

Follow us on Twitter

@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix renaming and schema changes for stored procedur
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix VPATH builds.