Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan andExplain analyze plan an error is displayed - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan andExplain analyze plan an error is displayed
Date
Msg-id CA+OCxoyT9yQU-ayjRa94UMaekGP7QhB3CNqaJ_A-j8t+4Jb4FA@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan andExplain analyze plan an error is displayed  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan andExplain analyze plan an error is displayed  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
List pgadmin-hackers
Hi Joao,

It looks like Jenkins has taken umbrage to this change, at least with Python 3.x. Can you take a look please?


Thanks.

On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patches applied.

On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,
This is quite a big patch in order to solve the problem with the Explain Plan.

We sent 2 patches that have the following:
- update-javascript-packages.diff 
    Add package:
     is-docker to select a specific setting when running the Chrome tests in
     Docker

    Upgrade the version of:
    - babel-loader
    - extract-text-webpack-plugin
    - jasmine-core
    - jasmine-enzyme
    - moment
- explain-plan-greenplum.diff
  Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
  Extract SQLEditor backend functions that start executing query to their own files and add tests around it
  Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
  Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type


Thanks
Joao



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python34 #466
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python35 #476