Re: pgAdmin4 PATCH: Domain Module - Mailing list pgadmin-hackers

From Dave Page
Subject Re: pgAdmin4 PATCH: Domain Module
Date
Msg-id CA+OCxoyRWtG4PR+jFgbDJi+S+Rbuazc7km+pXMK2zcCL4BzxUA@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin4 PATCH: Domain Module  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: pgAdmin4 PATCH: Domain Module
List pgadmin-hackers
On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi Dave,
>
> I have a query regarding your below feedback :
>
> - Default values should be auto-quoted when necessary (ie. strings, on a
> text-based domain).
>
> To resolve this, I have checked the typcategory field from pg_type for the
> base_type selected for the Domain.
> If the typcategory is String type  (i.e. S), then only I have used qtLiteral
> function to quote the default value.
>
> Is this right approach or not?

Yes, I think that's a good approach (at least, I don't see any
downsides right now :-) )



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: [PATCH] Enhancement in sql-field control [pgAdmin4]
Next
From: Dave Page
Date:
Subject: Re: PATCH: Updated catalog names [pgAdmin4]