Re: PATCH: Adding more confirmations in query tool (pgAdmin4) - Mailing list pgadmin-hackers

From Dave Page
Subject Re: PATCH: Adding more confirmations in query tool (pgAdmin4)
Date
Msg-id CA+OCxoy0ZVietUm3piNLjApyUwnqZBUGSUPq_ct=Mfh6WQn=DA@mail.gmail.com
Whole thread Raw
In response to PATCH: Adding more confirmations in query tool (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: PATCH: Adding more confirmations in query tool (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Hi

On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to add more confirmations in query tool before taking any actions
> which might cause lose changes,
> - Clearing editor
> - Clearing history
> - Load file data
>  RM#1666
>
> Please review.

Can you tweak it so that the confirmation is requested as soon as the
open file button is clicked, rather than when a file is selected
please? I think that's a little more 'normal' :-).

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix typo in connection handler.