Hi
This is fantastic! The speedup in the query tool is phenomenal with large result sets. For 96K rows, I'm now seeing 1 second until I can browse the data, vs. 13 in v1.4 (and 22 secs in pgAdmin 3)!! Awesome work Harshal :-)
Questions/comments:
- Can we put the row number in the left-hand column, to the right of the checkbox? This patch highlights just how much value that had in pgAdmin 3 (I hadn't realised we had missed it until now)
- If the user clicks the checkbox to select all rows, we need to retrieve them all at that time, otherwise they may be inadvertently working with a truncated result set.
- Are any changes needed to ensure the Download button works? I'm seeing missing rows in my test here, but that could be because of the known issues there with Unicode.
Thanks!