Re: Improve UX of YUM/DNF download form - Mailing list pgsql-www

From Dave Page
Subject Re: Improve UX of YUM/DNF download form
Date
Msg-id CA+OCxoxfCg2GFJ3GYRbFqrz-_P+=gXK6kKAt21-3Wf_GfGyKTA@mail.gmail.com
Whole thread Raw
In response to Re: Improve UX of YUM/DNF download form  (Dave Page <dpage@pgadmin.org>)
List pgsql-www
OK, patch applied. We provide instructions for installing the server in all cases.

Thanks!

On Tue, Jun 9, 2020 at 1:31 PM Dave Page <dpage@pgadmin.org> wrote:


On Tue, Jun 9, 2020 at 1:27 PM Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 6/9/20 7:58 AM, Dave Page wrote:
> So here's the updated patch following some discussion with Magnus:
>
> - Make the copyScript function more generic so it can be used elsewhere.
> - Don't include comments and blank lines in the copied text.
> - Move the css into main.css.
> - Add the actual install step to the Debian/Ubuntu instructions.
> - Improve naming of vars, classes, ids etc.
> - Ensure the copyScript function works fine with < > and so-on in the
> script.

That certainly changed a lot overnight ;)

LGTM. I don't have any additional comments on it, so I will give a +1.

Thanks. Any thoughts on the server vs. client thing?
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-www by date:

Previous
From: Dave Page
Date:
Subject: Re: Improve UX of YUM/DNF download form
Next
From: Stephen Frost
Date:
Subject: Buildfarm migration/upgrade