Re: SQLAlchemy updates for check tables. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: SQLAlchemy updates for check tables.
Date
Msg-id CA+OCxoxcT8u9VJPp_oEML0tL7D=sXFpy=jkFBz56K1ApQ=_Pfw@mail.gmail.com
Whole thread Raw
In response to Re: SQLAlchemy updates for check tables.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: SQLAlchemy updates for check tables.
List pgadmin-hackers


On Mon, Jul 19, 2021 at 9:58 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Mon, Jul 19, 2021 at 2:17 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jul 19, 2021 at 6:37 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for SQLAlchemy updates for check table is present in the database or not. (This will resolve load and dump server.)

How come this upstream change didn't fail the regression tests? 
Flask-SQLAlchemy is dependent on SQLAlchemy and which is an indirect dependency of pgAdmin, so if the installed version of Flask-SQLAlchemy is the latest one, it will be skipped.

Sure, but the regression test runs on the buildfarm build the venv from scratch on every run (as happens when we build the packages themselves). So I can see why local regression runs might have passed (as developers generally don't recreate their venv's from scratch before testing), but I would expect to have seen failures on the buildfarm. 

--

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: SQLAlchemy updates for check tables.
Next
From: Akshay Joshi
Date:
Subject: Re: Bug #6337 Patch