Re: [RM2522] Improve grid/column select all operation - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [RM2522] Improve grid/column select all operation
Date
Msg-id CA+OCxoxQQCMB6MU50COuzZ1ABHXnHEZpN=NZiBk1nmVKXXer=Q@mail.gmail.com
Whole thread Raw
In response to Re: [RM2522] Improve grid/column select all operation  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers


On Fri, Jun 30, 2017 at 9:39 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

This patch is not related to improve copy/past operation. It's only related to grid selection.
The improvement is only between when user clicks on grid select all column to until all row are selected (turned into blue). With large columns though improvement is not large but it not putting any overhead. Other hand with less columns but large row count the improvement it quite noticeable. Code change is only single line to use array concatenation instead of underscore union. I had look at union function implementation. It first flattens result set recursively and then removes duplicate which is not required in our case. All we want is indexes of complete rows in selected rows (ranges).


Ah, I see.

In that case, patch applied. Thanks!
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Improve speed of Select All in the results grid.Fixe
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid isextremely slow and fails with large datasets