Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Date
Msg-id CA+OCxoxE+OK3_KW_vu_pWY4+t5qyH985_Znp7v+uA2vmYRo2BQ@mail.gmail.com
Whole thread Raw
In response to [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
Responses Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
List pgadmin-hackers
Hi

On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for fixation of jenkins failure.

That won't work - you can't include variables (or string building operations) in the first argument to gettext calls, as there won't be any way to extract a complete message into the catalogs. The way it's being done at the moment is correct (I don't know why it's failing, but it's the correct way to structure the gettext calls).
 
--

pgadmin-hackers by date:

Previous
From: Rahul Shirsat
Date:
Subject: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Next
From: Rahul Shirsat
Date:
Subject: Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure