Postgres Pro
Downloads
Home   >   mailing lists

Re: Minor patch to fix reggression of select2 option - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Minor patch to fix reggression of select2 option
Date
Msg-id CA+OCxox4PoiyOoOgChX0XrjwtJaLESMJUiP+cqpaY3V+2p7+NQ@mail.gmail.com
Whole thread Raw
In response to Re: Minor patch to fix reggression of select2 option  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, applied.

Note to Akshay: When you tag 4.6, please make sure it is on the correct commit, and if we need to rewrap, you may need to move this issue to the 4.6 release notes.

Thanks!

On Tue, Apr 30, 2019 at 9:22 AM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

RM is 4218

Thanks,
Neel Patel

On Tue, Apr 30, 2019 at 1:25 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

What's the RM for this?

On Tue, Apr 30, 2019 at 8:00 AM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Team,

Please find attached patch to fix the issue where we should properly assigned 'dropdownParent'  select2 options.

This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717

Do review it and let us know for comments.

Thanks,
Neel Patel


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Properly assign dropdownParent in Select2 controls. F
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ensure popper.js is installed when needed. Fixes #421