Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/uppercase auto completion - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/uppercase auto completion
Date
Msg-id CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com
Whole thread Raw
In response to [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper caseauto completion  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/uppercase auto completion  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for the Feature #2686 Property to switch lower/upper case auto completion. I have added new preferences settings "Keywords in uppercase" if it is set to True then all the keywords are shown in upper case in auto completion.

I have also implemented the second request in the RM to change the selected text to upper/lower case. For that I have added new keyboard shortcut "Toggle case of selected text" in preferences dialog. Default key is "Ctrl + Shift + u".

Please review it. 

I don't see any doc updates in the patch - seems like that was forgotten?

Any opportunities to re-factor the code in that area into more testable functions? 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper caseauto completion
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The applicationserver could not be contacted