We reviewed the this patch and have some suggestions:
Python:
The functionality for adding the "can_prettify" is repeated in multiple places. Maybe this could be extracted into a function.
Javascript:
The class Backgrid.SizeFormatter doesn't seem to have any tests.
The function pg_size_pretty displays bytes and Kilobytes differently.
Is it possible to add PB as well?
Good idea. I'd also like to see a unit test added please Khushboo.
The function is a little bit hard to read, is it possible to refactor using private functions like:
fromRaw: function (rawData, model) { var unitIdx = findDataUnitIndex(rawData); if (unitIdx == 0) { return rawData + ' ' + this.dataUnits[i]; } return formatOutput(rawData, unitIdx);
},
In statistics.js:326 we believe it would make the code more readable if we change the variable "c" to "rawColumn" and "col" to "column".
SQL Files:
Is there a way to avoid conditionals here?
Maybe we can use the same javascript function to prettify all the sizes
Visually we saw a difference between "Databases" statistics and a specific database statistics. In "Databases" statistics the "Size" is "7.4 MB" but when you are in the specific database the "Size" is "7420 kB".
Is this the intended behavior?
Thanks
Joao & Sarah
On Tue, Apr 25, 2017 at 7:58 AM, Dave Page <dpage@pgadmin.org> wrote:
Removed the pg_size_pretty function from query for the collection and introduced the client side function to convert size into human readable format. So, the sorting issue is fixed as the algorithm will get the actual value of size instead of formatted value.