Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons
Date
Msg-id CA+OCxowvQogn-WyMih+0JvahrvaOLMiuFdy+20u8w26+tbuHog@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: Fix context menu fontawesome icons  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons
List pgadmin-hackers
Tree view
Hi

On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,

PFA minor patch to fix the font-awesome icon layout issue, attaching screenshot of an issue for your reference.

Regression of your commit: Link

I'm not sure this is the right way to fix this. We should re-add the left hand margin on the buttonbar menus and top-level menus. That's consistent with what the context menu looks like, but more importantly it's also consistent with (at least) macOS. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: pgAdmin4 not displaying schema if it startwith 'pg'
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans"for