This seems to work for the most part, however I saw what seemed like odd behaviour. If I have 2 query tool windows open;
- Changing a preference from the Preferences dialogue updates both query tools.
- Changing a preference from a Query Tool updates the Preferences dialogue.
- Changing a preference from a Query Tool does *not* update the other Query Tool.
The last point seems odd to me, though it also kinda makes sense to not have one query tool affect the other. The problem with that is that it could get quite confusing when they get out of sync. I think it would be better for a change in one Query Tool to update the other(s).
What do you think? Was this behaviour intentional?
(FYI, in case this was a one-off bug, I was testing using "Auto Commit?")
Attached is the patch for making preferences realtime and applying without reseting the layout. Please note, the patch is only for one module - SQL Editor and is the first part for the RM. There are lot of changes to be done to cover all and hence sending in parts. This will not affect/break existing code. Further patches will cover other modules.
Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of the main screen, Query tool, History entries in the query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will refer to single source of preferences which is cached in the Browser object. All other redundant ajax get preference calls are removed.
- SQL editor will not refer template JS variables anymore, once all the references are removed the template variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.
Request you to kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
--
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517 Mobile: +91 976-788-8246
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune