Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor
Date
Msg-id CA+OCxowDTWhOpvQopx1xsLdQe4JsiXSrx2rLTmF7roRt-Tru5g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sqleditor  (Jing Li <jingli@pivotal.io>)
List pgadmin-hackers


On Mon, Sep 11, 2017 at 11:13 AM, Jing Li <jingli@pivotal.io> wrote:
Can we get this patch into the 2.0 release?

Shouldn't be a problem. It didn't make todays build though.
 



On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezhang@pivotal.io wrote:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Fahar Abbas
Date:
Subject: Re: pgAdmin 4 v2.0-rc1 builds
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor