On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
Hi,
On Tue, 21 May 2024 at 18:24, Dave Page <dpage@pgadmin.org> wrote: > > > > On Tue, 21 May 2024 at 16:04, Andres Freund <andres@anarazel.de> wrote: >> >> Hi, >> >> On 2024-05-20 11:58:05 +0100, Dave Page wrote: >> > I have very little experience with Meson, and even less interpreting it's >> > logs, but it seems to me that it's not including the extra lib and include >> > directories when it runs the test compile, given the command line it's >> > reporting: >> > >> > cl C:\Users\dpage\git\postgresql\build\meson-private\tmpg_h4xcue\testfile.c >> > /nologo /showIncludes /utf-8 /EP /nologo /showIncludes /utf-8 /EP /Od /Oi- >> > >> > Bug, or am I doing something silly? >> >> It's a buglet. We rely on meson's internal fallback detection of zlib, if it's >> not provided via pkg-config or cmake. But it doesn't know about our >> extra_include_dirs parameter. We should probably fix that... > > > Oh good, then I'm not going bonkers. I'm still curious about how it works for Andrew but not me, however fixing that buglet should solve my issue, and would be sensible behaviour. > > Thanks!
I tried to install your latest zlib artifact (nmake one) to the Windows CI images (not the official ones) [1]. Then, I used the default meson.build file to build but meson could not find the zlib. After that, I modified it like you suggested before; I used a 'cc.find_library()' to find zlib as a fallback method and it seems it worked [2]. Please see meson setup logs below [3], does something similar to the attached solve your problem?
That patch does solve my problem - thank you!
The interesting thing is, I also tried this 'cc.find_library' method with your old artifact (cmake one). It was able to find zlib but all tests failed [4].
Very odd. Whilst I haven't used that particular build elsewhere, we've been building PostgreSQL and shipping client utilities with pgAdmin using cmake-built zlib for years.