Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum
Date
Msg-id CA+OCxowBzrTXJ1DLq_yAjKv9i46oP6UH9w_+xKgtFqEKJOYi1g@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Responses Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
List pgadmin-hackers
Hi

On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Dave,
No there is only tests around the the backendsupport function

Let me rephrase :-). What's this part of the patch for?

--- a/web/pgadmin/feature_tests/keyboard_shortcut_test.py
+++ b/web/pgadmin/feature_tests/keyboard_shortcut_test.py
@@ -7,9 +7,10 @@
 #
 ##########################################################################
 
-import os
-import json
+from __future__ import print_function
 import time
+import sys
+
 from selenium.webdriver.support.ui import WebDriverWait
 from selenium.webdriver.support import expected_conditions as EC
@@ -64,6 +65,8 @@ class KeyboardShortcutFeatureTest(BaseFeatureTest):
                 Keys.ALT
             ).perform()
 
+            print("Executing shortcut: " + self.new_shortcuts[s]['locator'] + "...", file=sys.stderr, end="")
+
             self.wait.until(
                 EC.presence_of_element_located(
                     (By.XPATH, "//li[contains(@id, " +
@@ -76,6 +79,8 @@ class KeyboardShortcutFeatureTest(BaseFeatureTest):
 
             assert is_open is True, "Keyboard shortcut change is unsuccessful."
 
+            print("OK", file=sys.stderr)


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum