Re: json_query conditional wrapper bug - Mailing list pgsql-hackers

From Amit Langote
Subject Re: json_query conditional wrapper bug
Date
Msg-id CA+HiwqHN87fCiOyEJga1X_OTLE=FjUvi3ueFoSKaoqAi+CdG4w@mail.gmail.com
Whole thread Raw
In response to json_query conditional wrapper bug  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On Thu, Sep 12, 2024 at 8:12 PM Amit Langote <amitlangote09@gmail.com> wrote:
>
> Hi Andreas,
>
> On Thu, Sep 12, 2024 at 7:08 PM Andreas Ulbrich
> <andreas.ulbrich@matheversum.de> wrote:
> >
> > Salvete!
> >
> >
> > Sorry for my out of the rules replay, but I'm not at home, and also I can't verify and check your patch.
> >
> > But I think you have missed the docu in your fix:
> >
> > Must the example there not also be changed:
> >
> > From
> >
> > JSON_QUERY(jsonb '[1,[2,3],null]', 'lax $[*][$off]' PASSING 1 AS off WITH CONDITIONAL WRAPPER) → [3]
> >
> > to
> >
> > JSON_QUERY(jsonb '[1,[2,3],null]', 'lax $[*][$off]' PASSING 1 AS off WITH CONDITIONAL WRAPPER) → 3
>
> You're right, good catch.
>
> I had checked whether the documentation text needed fixing, but failed
> to notice that an example
> is using CONDITIONAL.  Will fix, thanks for the report.

I have pushed the fix.  Thanks Andreas for the report.

--
Thanks, Amit Langote



pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Add has_large_object_privilege function
Next
From: Tender Wang
Date:
Subject: Re: Eager aggregation, take 3