Request a Demo
Home   >   mailing lists

Re: More speedups for tuple deformation - Mailing list pgsql-hackers

From Amit Langote
Subject Re: More speedups for tuple deformation
Date
Msg-id CA+HiwqGUXF_iwCHZepH7vM=AZCwDdeesQzwd=OO3i1=F-KouPA@mail.gmail.com
Whole thread
In response to Re: More speedups for tuple deformation  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: More speedups for tuple deformation
List pgsql-hackers
Tree view 
Hi David,

On Tue, Feb 24, 2026 at 11:23 AM David Rowley <dgrowleyml@gmail.com> wrote:
> I've attached an updated version of the patch (v9).

I noticed what looks like some rebase noise in TupleDescFinalize():

        off = att_nominal_alignby(off, cattr->attalignby);

        /*
         * attcacheoff is an int16, so don't try and cache any offsets larger
         * than will fit in that type.
         */
        if (off > PG_INT16_MAX)
            break;

        cattr->attcacheoff = off;

        /*
         * attcacheoff is an int16, so don't try and cache any offsets larger
         * than will fit in that type.
         */
        if (off > PG_INT16_MAX)
            break;

        cattr->attcacheoff = off;

--
Thanks, Amit Langote

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Add errdetail() with PID and UID about source of termination signal
Next
From: Dean Rasheed
Date:
Subject: Re: MERGE behavior with REPEATABLE READ isolation level