Re: pg_overexplain produces invalid JSON with RANGE_TABLE option - Mailing list pgsql-hackers

From Amit Langote
Subject Re: pg_overexplain produces invalid JSON with RANGE_TABLE option
Date
Msg-id CA+HiwqGLK2QzHFZcwJ-+CbNy7BFB2=G_Ce0eSfPzCOGg6+=USw@mail.gmail.com
Whole thread
In response to Re: pg_overexplain produces invalid JSON with RANGE_TABLE option  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
On Thu, Apr 16, 2026 at 9:06 AM Amit Langote <amitlangote09@gmail.com> wrote:
> On Thu, Apr 16, 2026 at 6:36 AM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> >
> > Hi Hackers,
> >
> > It appears that pg_overexplain produces invalid JSON output when
> > EXPLAIN (FORMAT JSON, RANGE_TABLE) is used. The "Unprunable RTIs" and
> > "Result RTIs" properties are emitted as key:value pairs directly inside
> > the "Range Table" JSON array, which is structurally invalid.
>
> Thanks for the report and the patch.  That makes sense.
>
> > Attempted to fix this by moving ExplainCloseGroup() before the two overexplain_bitmapset()
> > calls, so the properties are emitted as siblings of "Range Table" in the parent object rather
> > than inside the array.
> >
> > Attached a patch to address this which also includes a test.
>
> I have added a commit message.  Will commit shortly to master and v18.

Pushed.

--
Thanks, Amit Langote



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Introduce XID age based replication slot invalidation
Next
From: Amit Langote
Date:
Subject: Re: [PATCH] Fix wrong comment in JsonTablePlanJoinNextRow()