On Fri, Sep 19, 2025 at 11:05 AM David Rowley <dgrowleyml@gmail.com> wrote:
> On Thu, 18 Sept 2025 at 20:25, Amit Langote <amitlangote09@gmail.com> wrote:
> >
> > On Thu, Sep 18, 2025 at 4:06 PM David Rowley <dgrowleyml@gmail.com> wrote:
> > > I think the original intent of "Parsed test spec with 3 sessions"
> > > (from 759d9d676) was two sessions doing work, and an independent
> > > observer session. Is there a reason to add 2 more sessions? Maybe it's
> > > me not working with the isolation tester often enough, but I'd have
> > > expected you to add steps for s1 and s2 then define permutations for
> > > those steps.
> >
> > Yeah, that makes the additions smaller and avoids slowing down the
> > suite. It did take a bit of fiddling though -- after switching to use
> > the existing sessions, teardown in s1 hung because I hadn’t noticed
> > that s2’s setup already does a BEGIN, so the delete side ended up
> > without a COMMIT, leaving an open transaction that blocked DROP in
> > s1’s teardown. Easier to take shortcuts with new sessions like I
> > first did, but better to keep the suite light. :-)
> >
> > Done in the attached.
>
> Thanks for updating. Looks good. I verified the test fails with the
> code change reverted and passes with the change.
Thanks for checking, pushed.
--
Thanks, Amit Langote
