On Mon, Oct 21, 2019 at 5:44 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Sat, Oct 19, 2019 at 5:56 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > On Fri, Oct 18, 2019 at 6:56 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > > On 2019-Oct-18, Etsuro Fujita wrote:
> > > > While reviewing the partitionwise-join patch, I noticed $Subject，ie,
> > > > this in create_list_bounds():
> > > >
> > > > /*
> > > > * Never put a null into the values array, flag instead for
> > > > * the code further down below where we construct the actual
> > > > * relcache struct.
> > > > */
> > > > if (null_index != -1)
> > > > elog(ERROR, "found null more than once");
> > > > null_index = i;
> > > >
> > > > "the code further down below where we construct the actual relcache
> > > > struct" isn't in the same file anymore by refactoring by commit
> > > > b52b7dc25. How about modifying it like the attached?
> > >
> > > Yeah, agreed. Instead of "the null comes from" I would use "the
> > > partition that stores nulls".
> >
> > I think your wording is better than mine. Thank you for reviewing!
>
> I applied the patch down to PG12.
Thank you Fujita-san and Alvaro.
Regards,
Amit
