Postgres Pro
Downloads
Home   >   mailing lists

Re: making update/delete of inheritance trees scale better - Mailing list pgsql-hackers

From Amit Langote
Subject Re: making update/delete of inheritance trees scale better
Date
Msg-id CA+HiwqEKNQji7UcudugaYRHUx8ca67Qxe_Kgfe9BLS6trAVO7A@mail.gmail.com
Whole thread Raw
In response to RE: making update/delete of inheritance trees scale better  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses RE: making update/delete of inheritance trees scale better
List pgsql-hackers
Tree view 
Hi,

On Mon, May 17, 2021 at 3:07 PM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> Hi
>
> After 86dc900, In " src/include/nodes/pathnodes.h ",
> I noticed that it uses the word " partitioned UPDATE " in the comment above struct RowIdentityVarInfo.
>
> But, it seems " inherited UPDATE " is used in the rest of places.
> Is it better to keep them consistent by using " inherited UPDATE " ?

Yeah, I would not be opposed to fixing that.  Like this maybe (patch attached)?

- * In partitioned UPDATE/DELETE it's important for child partitions to share
+ * In an inherited UPDATE/DELETE it's important for child tables to share

While at it, I also noticed that the comment refers to the
row_identity_vars, but it can be unclear which variable it is
referring to.  So fixed that too.

-- 
Amit Langote
EDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Next
From: Peter Smith
Date:
Subject: "ERROR: deadlock detected" when replicating TRUNCATE