Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Performance Improvement For Copy From Binary Files - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [PATCH] Performance Improvement For Copy From Binary Files
Date
Msg-id CA+HiwqEKHz-=GqD3jx9suk83yfDv_ivM_3ZfCeu6koQCet9Sjw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Performance Improvement For Copy From Binary Files  (vignesh C <vignesh21@gmail.com>)
Responses Re: [PATCH] Performance Improvement For Copy From Binary Files
List pgsql-hackers
Tree view 
Hi Vignesh,

On Tue, Jul 14, 2020 at 10:23 PM vignesh C <vignesh21@gmail.com> wrote:
> On Tue, Jul 14, 2020 at 11:19 AM Amit Langote <amitlangote09@gmail.com> wrote:
> > Sounds fine to me.  Although CopyLoadRawBuf() does not seem to a
> > candidate for rigorous code optimization as it does not get called
> > that often.
>
> I thought we could include that change as we are making changes around
> that code.

Sure, done.

> Rest of the changes looked fine to me. Also I noticed that
> commit message was missing in the patch.

Please see the attached v7.

-- 
Amit Langote
EnterpriseDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Binary support for pgoutput plugin
Next
From: Alexander Korotkov
Date:
Subject: Re: WIP: BRIN multi-range indexes