Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Do not use StdRdOptions in Access Methods - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [PATCH] Do not use StdRdOptions in Access Methods
Date
Msg-id CA+HiwqEESm7FO-AkAmVnnDHwR+tk+Fw9By_RPY13A--+T2S4cA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Do not use StdRdOptions in Access Methods  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Do not use StdRdOptions in Access Methods
List pgsql-hackers
Tree view 
Hello,

On Thu, Nov 21, 2019 at 2:22 PM Michael Paquier <michael@paquier.xyz> wrote:
> Any opinions or objections to share regarding the recent
> progress done?

The latest patch looks good to me, except, maybe the comment of
StdRdOptions should be updated:

 * StdRdOptions
 *      Standard contents of rd_options for heaps and generic indexes.

IIUC, StdRdOptions no longer applies to indexes, right?

Thanks,
Amit

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Attempt to consolidate reading of XLOG page
Next
From: Mark Dilger
Date:
Subject: Assertion failing in master, predicate.c