Re: gram.y comment issue - Mailing list pgsql-bugs

From Amit Langote
Subject Re: gram.y comment issue
Date
Msg-id CA+HiwqE=_VkCvzUATY5GUTwiBFbXRpQzKLg4yjGm7Hn1=c4Wyg@mail.gmail.com
Whole thread Raw
In response to gram.y comment issue  (张文升 <wensheng.zhang@qunar.com>)
Responses Re: gram.y comment issue
List pgsql-bugs
On Wed, Mar 9, 2016 at 3:04 PM, =E5=BC=A0=E6=96=87=E5=8D=87 <wensheng.zhang=
@qunar.com> wrote:
> The gram.y  includes the line(line:1965):
> /* ALTER TABLE <name> ALTER [COLUMN] <colname> SET ( column_parameter =3D
> value [, ... ] ) */
> ALTER opt_column ColId RESET reloptions
>
> The comment has the word "SET", but I think that's should be "RESET".

This one needs to be fixed.

> src/include/nodes/parsenodes.h line:141
> List      *distinctClause; /* a list of SortGroupClause's */
> The comment has the word "SortGroupClause", but that's should be
> "distinctClause".

This one is fine.  The name distinctClause here is parser's way of
referring to the SQL construct DISTINCT ON (<list-of-items>) in a
SELECT query, where each member of the list is a SortGroupClause item.

Thanks,
Amit

pgsql-bugs by date:

Previous
From: 张文升
Date:
Subject: gram.y comment issue
Next
From: Tom Lane
Date:
Subject: Re: gram.y comment issue